Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheres my RA release #1120

Merged
merged 97 commits into from
Dec 16, 2024
Merged

Wheres my RA release #1120

merged 97 commits into from
Dec 16, 2024

Conversation

RossClark01
Copy link
Contributor

@RossClark01 RossClark01 commented Dec 12, 2024

Changes from code review are included here

RossClark01 and others added 30 commits October 10, 2024 18:38
… us to maintain data in eisiting databases and make views as needed. RA_ID and Hall_ID are indirectly ties to existing tables
Added api to delete room range from the range id
WMR - Added view for Halls and updated tasks to be hall dependent
added api to assign ra to a room range and an api to find the assigned ra based on a resident housing assignment
Room range api
wmr - Schedule a status for RA/AC schedules
RossClark01 and others added 22 commits December 4, 2024 20:13
Added API to check RA Pref Contact Method
…oups for RDs,RAs, and Hall viewers.

For testing purposes added Housing developers as bypassers of api auth checking. This MUST be removed before merging. I would like to test the api permissions on real RA's and RD's to test functionality
…termine if the housing page gets displayed for a given user
Added StateYourBusiness for API route protecting. Added new auth gr…
API to determine if a student is residential. This will be used to de…
Route name changes
removed unneeded try catch blocks
adjusted string to int for room ranges
@RossClark01 RossClark01 added the WheresMyRAProject24-25 Related to the Where's My RA Senior Project label Dec 12, 2024
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment about removing universal privileges from the dev group before merging into develop.

Gordon360/Authorization/StateYourBusiness.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this is ready to merge into develop.

@russtuck russtuck merged commit 7e2dcd1 into develop Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WheresMyRAProject24-25 Related to the Where's My RA Senior Project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants