Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wmr - Reworked GetResidentRA API route #1092

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

jtasonye
Copy link
Contributor

@jtasonye jtasonye commented Nov 10, 2024

Changes made in PR:

  • Changed HousingService.cs file: This function only returned the RA's ID, so I reworked it to use a join query so that we can get the RA's name from the RA_Assigned_Ranges_View based on the RA_ID from RA_Assigned_Ranges

  • Changed HousingController.cs file: Instead of using the FromQuery method, I added hall Id and room Number as parameters in the GET method, which made it easier to use the route on the front-end

  • I also did the logic for the frontend [https://github.com/wmr - Display the full name of resident's RA gordon-360-ui#2417], so once Mya merges that and once you merge this request, you should be able to see the assigned RA based on the resident's room number

@jtasonye jtasonye requested a review from RossClark01 November 10, 2024 07:34
Copy link
Contributor

@RossClark01 RossClark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me sir! It will be helpful to get all that info at once rather than making multiple calls

@RossClark01 RossClark01 merged commit d9bf4c1 into wheres-my-ra Nov 12, 2024
3 checks passed
@jtasonye jtasonye self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants