wmr - Reworked GetResidentRA API route #1092
Merged
+33
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in PR:
Changed
HousingService.cs
file: This function only returned the RA's ID, so I reworked it to use a join query so that we can get the RA's name from theRA_Assigned_Ranges_View
based on the RA_ID fromRA_Assigned_Ranges
Changed
HousingController.cs
file: Instead of using theFromQuery
method, I addedhall Id
androom Number
as parameters in theGET
method, which made it easier to use the route on the front-endI also did the logic for the frontend [https://github.com/wmr - Display the full name of resident's RA gordon-360-ui#2417], so once Mya merges that and once you merge this request, you should be able to see the assigned RA based on the resident's room number