Fixes Switch Break Bug #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug can be seen when trying to compile Tests/FuzzilliTests/CompilerTests/switch_statements.js, which fails because "break statement outside of loop or switch", even though it isn't. This happens because breaks are expected in the switch cases, rather than the switch block. This was missed because compilation was succesful before making the Analyzer changes a seperate branch and verification of the new ContextAnalyzer was only done with Tests/FuzzilliTests/AnalyzerTest.swift and not with Tests/CompilerTests/switch_statements.js
|
Ah good catch! Yeah I guess this happens in part because the .switchBlock context is not propagated into the cases, but I think that needs to be this way, otherwise we might end up with SwitchCase blocks inside other SwitchCase blocks, which isn't valid. Anyway, thanks for the fix! |
parthdt
pushed a commit
to parthdt/fuzzilli
that referenced
this pull request
Dec 14, 2024
Bug can be seen when trying to compile Tests/FuzzilliTests/CompilerTests/switch_statements.js, which fails because "break statement outside of loop or switch", even though it isn't. This happens because breaks are expected in the switch cases, rather than the switch block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug can be seen when trying to compile Tests/FuzzilliTests/CompilerTests/switch_statements.js, which fails because "break statement outside of loop or switch", even though it isn't. This happens because breaks are expected in switch cases, rather than the switch block.
This was missed because compilation was succesful before moving the Analyzer changes to a separate branch and verification of the new ContextAnalyzer was only done with Tests/FuzzilliTests/AnalyzerTest.swift and not with Tests/CompilerTests/switch_statements.js