feat(x-goog-spanner-request-id): add bases #2211
Conversation
product-auto-label
bot
added
size: l
|
Kindly pinging @olavloite @surbhigarg92 to help bring this in as it is carved out of the larger PR #2205 and is isolated away from main code. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
src/request_id_header.ts
Outdated
| @@ -0,0 +1,327 @@ | |||
| /*! | |||
There was a problem hiding this comment.
nit:
| /*! | |
| /** |
src/request_id_header.ts
Outdated
| const X_GOOG_SPANNER_REQUEST_ID_HEADER = 'x-goog-spanner-request-id'; | ||
|
|
||
| class AtomicCounter { | ||
| private backingBuffer: Uint32Array; |
There was a problem hiding this comment.
| private backingBuffer: Uint32Array; | |
| private readonly backingBuffer: Uint32Array; |
|
|
||
| constructor(initialValue?: number) { | ||
| this.backingBuffer = new Uint32Array( | ||
| new SharedArrayBuffer(Uint32Array.BYTES_PER_ELEMENT) |
There was a problem hiding this comment.
I am not familiar with this in Node.js, but while looking into what this is, I ran into this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#security_requirements
Does this affect the usability of this in Node.js? Or is this an issue that is only relevant to code running in a browser?
There was a problem hiding this comment.
Yeah, that's for browsers.
src/request_id_header.ts
Outdated
| nthRequest: number, | ||
| attempt: number | ||
| ) { | ||
| return `1.${randIdForProcess}.${nthClientId}.${channelId}.${nthRequest}.${attempt}`; |
There was a problem hiding this comment.
nit: Can we add a comment that explains why there is a '1' at the start of this string, e.g.:
// The first digit in this string is the version number of the header type that is used.
src/request_id_header.ts
Outdated
|
|
||
| const X_GOOG_REQ_ID_REGEX = /(\d+\.){5}\d+/; | ||
|
|
||
| class XGoogRequestHeaderInterceptor { |
There was a problem hiding this comment.
If I understand this correctly, this is a server interceptor, meaning that it will be used for testing, right? Could we then move this to a test file?
There was a problem hiding this comment.
Done and thankyou @olavloite, please take a look.
src/request_id_header.ts
Outdated
| const prefixesToIgnore: string[] = that.prefixesToIgnore || []; | ||
| for (i = 0; i < prefixesToIgnore.length; i++) { | ||
| const prefix = prefixesToIgnore[i]; | ||
| // console.log(`prefix: ${prefix}\nmethod: ${method}`); |
|
|
||
| function injectRequestIDIntoHeaders( | ||
| headers: {[k: string]: string}, | ||
| session: any, |
There was a problem hiding this comment.
Could we make this typed?
There was a problem hiding this comment.
That would create an import cycle because Session also then uses injectRequestIDIntoHeaders in the follow-up PR.
This change brings in the bases for x-goog-spanner-request-id by commit AtomicCounter and the various utilities plus some unit tests. Ripped out of PR googleapis#2205 Updates googleapis#2200
odeke-em
force-pushed
the
x-goog-spanner-request-id-bases
branch
2 times, most recently
from
02faead to
e82d493
Compare
odeke-em
force-pushed
the
x-goog-spanner-request-id-bases
branch
from
e82d493 to
60204be
Compare
This change brings in the bases for x-goog-spanner-request-id by commit AtomicCounter and the various utilities plus some unit tests.
Ripped out of PR #2205
Updates #2200