ci(spanner): use airlock for presubmit jobs #2199
Draft
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files: |
product-auto-label
bot
added
size: s
sakthivelmanii
force-pushed
the
use-airlock-for-presubmit-jobs
branch
from
137e50c to
08dddf6
Compare
surbhigarg92
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
sakthivelmanii
force-pushed
the
use-airlock-for-presubmit-jobs
branch
from
3ef6509 to
ffaf8e6
Compare
sakthivelmanii
force-pushed
the
use-airlock-for-presubmit-jobs
branch
from
ffaf8e6 to
d851939
Compare
suztomo
reviewed
Jan 9, 2025
Comment on lines
+43
to
+45
| # Setup service account credentials. | ||
| export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account | ||
| export GCLOUD_PROJECT=long-door-651 |
There was a problem hiding this comment.
Does this change (moving the lines) really matter?
| @@ -16,11 +16,9 @@ | |||
|
|
|||
| set -eo pipefail | |||
|
|
|||
| export NPM_CONFIG_PREFIX=${HOME}/.npm-global | |||
There was a problem hiding this comment.
Does this change (moving the lines) really matter?
There was a problem hiding this comment.
Yes. it depends on which SA Airlock uses. I am using Kokoro SA here. Moving line below makes to use Kokoro GCP pool SA.
| @@ -164,7 +164,8 @@ if [[ -n "${KOKORO_BUILD_ID:-}" ]]; then | |||
| "KOKORO_GITHUB_PULL_REQUEST_COMMIT" | |||
| # For flakybot | |||
| "KOKORO_GITHUB_COMMIT_URL" | |||
| "KOKORO_GITHUB_PULL_REQUEST_URL" | |||
| "KOKORO_GITHUB_PULL_REQUEST_URL", | |||
| "ENABLE_AIRLOCK" | |||
| } | ||
|
|
||
| env_vars: { | ||
| key: "ENABLE_AIRLOCK", |
There was a problem hiding this comment.
Shall we use USE_AIRLOCK as consistent environment variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕