feat(langgraph-base): create async get_tuple method + tests #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: alloydb
averikitsch
reviewed
Jan 23, 2025
|
Please reopen when there are changes. |
|
@averikitsch how can I open the PR? |
|
/gcbrun |
|
/gcbrun |
averikitsch
requested changes
Feb 12, 2025
Comment on lines
+442
to
+445
| result = await conn.execute(text(query), args) | ||
| result_map = result.mappings() | ||
| results = result_map.fetchall() | ||
| for value in results: |
There was a problem hiding this comment.
To be truly async we need to fetch asynchronously not fetchall into memory.
Suggested change
| result = await conn.execute(text(query), args) | |
| result_map = result.mappings() | |
| results = result_map.fetchall() | |
| for value in results: | |
| result_proxy = await conn.execute(text(query), args) | |
| while True: | |
| value = result_proxy.fetchone() |
| ) | ||
| from langgraph.checkpoint.serde.base import SerializerProtocol | ||
| from langgraph.checkpoint.serde.jsonplus import JsonPlusSerializer | ||
| from langgraph.checkpoint.serde.types import TASKS | ||
| from langgraph.checkpoint.serde.types import TASKS |
Comment on lines
29
to
30
| CheckpointTuple, | ||
| get_checkpoint_id, |
| AND cw.checkpoint_id = c.parent_checkpoint_id | ||
| AND cw.channel = '{TASKS}' | ||
| ) AS pending_sends | ||
| FROM "{self.schema_name}".'{CHECKPOINTS_TABLE}' c |
There was a problem hiding this comment.
Please use double quotes around all table name
| metadata, | ||
| ( | ||
| SELECT array_agg(array[cw.task_id::text::bytea, cw.channel::bytea, cw.type::bytea, cw.blob] order by cw.task_id, cw.idx) | ||
| FROM "{self.schema_name}".'{CHECKPOINT_WRITES_TABLE}' cw |
There was a problem hiding this comment.
All table names should refer to the self.table_name and self.table_name_writes
| }, | ||
| checkpoint=self._load_checkpoint( | ||
| value["checkpoint"], | ||
| value["channel_values"], |
There was a problem hiding this comment.
How are we calculating this?
| async with self.pool.connect() as conn: | ||
| result = await conn.execute(text(SELECT + where), args) | ||
| result_map = result.mappings() | ||
| results = result_map.fetchall() |
|
averikitsch
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Can you copy in the tests that use get_tuple from https://github.com/langchain-ai/langgraph/blob/909190cede6a80bb94a2d4cfe7dedc49ef0d4127/libs/langgraph/tests/test_prebuilt.py
At some point we will also want larger tests like https://github.com/langchain-ai/langgraph/blob/909190cede6a80bb94a2d4cfe7dedc49ef0d4127/libs/langgraph/tests/test_pregel.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log:
[ ] Create async get_tuple method
[ ] Create test for method