fix: always add instance-id for built-in metrics #3612
Merged
+188
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instance-id was only added for built-in metrics when the headers of the request was sent. This meant that any request that would NOT get sent would not include an instance-id, which again would cause the export of ALL built-in metrics to stop. This would happen because the metric without an instance-id would remain in the collected metrics. A request would get into this state if the client ran into a network issue that would prevent the client from making a network connection to Spanner. Fixes #3611
product-auto-label
bot
added
size: m
surbhigarg92
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instance-id was only added for built-in metrics when the headers of the request was sent. This meant that any request that would NOT get sent would not include an instance-id, which again would cause the export of ALL built-in metrics to stop. This would happen because the metric without an instance-id would remain in the collected metrics.
A request would get into this state if the client ran into a network issue that would prevent the client from making a network connection to Spanner.
Fixes #3611