feat: disable affinity for grpc-gcp when there is no channel hint. #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
psinghbay1
approved these changes
Jul 14, 2024
harshachinta
added
the
do not merge
|
Closing as there has not been any activity in the past several weeks. Please re-open if this is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpannerOptions#enableGrpcGcpExtension enabled GRPC GCP extension which is a separate library that handles channel management. By default this assumes session to channel affinity.
With multiplexed session we no longer maintain any channel hint with the session. However, grpc-gcp would still assume session to channel affinity and that may cause higher latencies. This change disables affinity whenever there is no channel hint associated with the session. Effectively this will disable affinity when multiplexed sessions are launched.