Skip to content

Commit

Permalink
address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
parthea committed Jan 16, 2025
1 parent 67cf899 commit 13bef06
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions scripts/configure_release_please/configure_release_please.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,11 @@ def configure_release_please_manifest(
if f"packages/{package_dir.name}" not in manifest_json:
manifest_json[f"packages/{package_dir.name}"] = "0.0.0"

if not package_supports_gapic_version(package_dir):
continue
gapic_version_file = next(package_dir.rglob("**/gapic_version.py"), None)
if gapic_version_file is None:
if package_supports_gapic_version(package_dir):
raise Exception("Failed to find gapic_version.py")
else:
continue
raise Exception("Failed to find gapic_version.py")
version = get_version_for_package(gapic_version_file)
# check the version in gapic_version.py and update if newer than the default which is
# 0.0.0 or 0.1.0.
Expand Down

0 comments on commit 13bef06

Please sign in to comment.