Skip ErrorTypes in Types#directSupertypes for compatibility with …

…javac. PiperOrigin-RevId: 715569286
google · Jan 15, 2025 · 370011c · 370011c
1 parent 706588c
commit 370011c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/java/com/google/turbine/processing/TurbineTypes.java b/java/com/google/turbine/processing/TurbineTypes.java
@@ -877,7 +877,10 @@ private ImmutableList<Type> directSupertypes(ClassTy t) {
       builder.add(ClassTy.OBJECT);
     }
     for (Type interfaceType : info.interfaceTypes()) {
-      builder.add(raw ? erasure(interfaceType) : subst(interfaceType, mapping));
+      // ErrorTypes are not included in directSupertypes for compatibility with javac
+      if (interfaceType.tyKind() == TyKind.CLASS_TY) {
+        builder.add(raw ? erasure(interfaceType) : subst(interfaceType, mapping));
+      }
     }
     return builder.build();
   }

diff --git a/javatests/com/google/turbine/processing/ProcessingIntegrationTest.java b/javatests/com/google/turbine/processing/ProcessingIntegrationTest.java
@@ -436,6 +436,23 @@ public void superType() throws IOException {
     assertThat(diags).containsExactly("could not resolve S", "S [S]").inOrder();
   }
 
+  @Test
+  public void superTypeInterfaces() throws IOException {
+    ImmutableList<Tree.CompUnit> units =
+        parseUnit(
+            "=== T.java ===", //
+            "abstract class T implements NoSuch, java.util.List<String> {",
+            "}");
+    TurbineError e = runProcessors(units, new SuperTypeProcessor());
+    ImmutableList<String> diags =
+        e.diagnostics().stream().map(d -> d.message()).collect(toImmutableList());
+    assertThat(diags)
+        .containsExactly(
+            "could not resolve NoSuch",
+            "java.lang.Object [java.lang.Object, java.util.List<java.lang.String>]")
+        .inOrder();
+  }
+
   @SupportedAnnotationTypes("*")
   public static class GenerateAnnotationProcessor extends AbstractProcessor {