Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syz-cluster/pkg/report: add an email template #5800

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

a-nogikh
Copy link
Collaborator

The first revision of the email template that will be used for reporting the findings.

This PR adds more fields to the pkg/api package, but these are not filled by the implementation yet. That will be done separately.

@a-nogikh a-nogikh force-pushed the features/cluster-email-template branch from d7c9f72 to 969fe2f Compare February 18, 2025 16:38
@a-nogikh
Copy link
Collaborator Author

I can't really understand why the two CI tests failed here:

Error: Error: failed to run script step: command terminated with non-zero exit code: error executing command [sh -e /__w/_temp/22de30a0-ee17-11ef-a2dc-15adb048a8d4.sh], exit code 2
Error: Process completed with exit code 1.
Error: Executing the custom container implementation failed. Please contact your self hosted runner administrator.

@a-nogikh a-nogikh force-pushed the features/cluster-email-template branch from 969fe2f to db18c47 Compare February 18, 2025 17:13
@@ -0,0 +1,44 @@
syzbot has found the following issue(s) in the series
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramosian-glider @melver please also take a look, this is what we are going to send to kernel mailing lists

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's short and crisp which is good.

Only thing that might be worthwhile is more clearly spelling out how to reproduce the issues, because I think that's going to be the most effective thing a developer can do to check their work. It's likely too inefficient to wait for syzbot to retest (if that's even planned) changes before it's sent as a v+1.

I see links to config, and mention of arch and compiler, but besides that it's unclear how I'd go about trying to reproduce the problem.

The first revision of the email template that will be used for
reporting the findings.

This PR adds more fields to the pkg/api package, but these are not
filled by the implementation yet. That will be done separately.
@a-nogikh a-nogikh force-pushed the features/cluster-email-template branch from db18c47 to 23e3815 Compare February 19, 2025 10:17
Copy link
Collaborator

@melver melver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@dvyukov dvyukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and improve later.

@a-nogikh a-nogikh added this pull request to the merge queue Feb 19, 2025
Merged via the queue into google:master with commit b257a9b Feb 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants