-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more lockfile extractors #1518
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 68.98% 69.01% +0.02%
==========================================
Files 197 197
Lines 18800 18791 -9
==========================================
- Hits 12970 12969 -1
+ Misses 5127 5119 -8
Partials 703 703 ☔ View full report in Codecov by Sentry. |
fwiw if you wait a little longer we'll hopefully be able to also add |
Do we want to add any tests here? @another-rex Or can we assume that the extractors are already well tested in OSV-Scalibr and the integration here doesn't introduce any new points of failure? |
We should copy some tests fixtures from scalibr into our main_test fixtures. We might not even need to add any new tests there, just update the snapshots after moving some new fixtures in. |
@G-Rath yes I do plan to wait for |
This PR adds more lockfile extractors supported in OSV-Scalibr.