Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more lockfile extractors #1518

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Jan 21, 2025

This PR adds more lockfile extractors supported in OSV-Scalibr.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (14686b9) to head (1c4ddf8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
+ Coverage   68.98%   69.01%   +0.02%     
==========================================
  Files         197      197              
  Lines       18800    18791       -9     
==========================================
- Hits        12970    12969       -1     
+ Misses       5127     5119       -8     
  Partials      703      703              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review January 21, 2025 05:54
@cuixq cuixq requested a review from another-rex January 21, 2025 05:54
@G-Rath
Copy link
Collaborator

G-Rath commented Jan 22, 2025

fwiw if you wait a little longer we'll hopefully be able to also add bun.lock

@oliverchang
Copy link
Collaborator

Do we want to add any tests here? @another-rex

Or can we assume that the extractors are already well tested in OSV-Scalibr and the integration here doesn't introduce any new points of failure?

@oliverchang oliverchang reopened this Jan 22, 2025
@another-rex
Copy link
Collaborator

We should copy some tests fixtures from scalibr into our main_test fixtures. We might not even need to add any new tests there, just update the snapshots after moving some new fixtures in.

@cuixq
Copy link
Contributor Author

cuixq commented Jan 22, 2025

@G-Rath yes I do plan to wait for bun.lock - sending out for some high-level review first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants