Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatementSwitchToExpressionSwitch] when assigning from a switch on enum, if the switch has a default: clause and is otherwise exhaustive (even without said default: clause), then propose an alternative fix which removes the default: clause and its code. #4751

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Jan 7, 2025

[StatementSwitchToExpressionSwitch] when assigning from a switch on enum, if the switch has a default: clause and is otherwise exhaustive (even without said default: clause), then propose an alternative fix which removes the default: clause and its code.

The first fix always retains the default: clause.

@copybara-service copybara-service bot force-pushed the test_712971198 branch 2 times, most recently from 62a735d to 9b77e83 Compare January 7, 2025 20:37
@copybara-service copybara-service bot changed the title [StatementSwitchToExpressionSwitch] when switching on an enum, if the switch has a default: clause and the switch is exhaustive even without said default: clause, then propose an alternative fix which removes the default: clause and its code. [StatementSwitchToExpressionSwitch] when assigning from a switch on enum, if the switch has a default: clause and is otherwise exhaustive (even without said default: clause), then propose an alternative fix which removes the default: clause and its code. Jan 7, 2025
@copybara-service copybara-service bot force-pushed the test_712971198 branch 3 times, most recently from 781a062 to 760f9a1 Compare January 8, 2025 20:26
…num, if the switch has a `default:` clause and is otherwise exhaustive (even without said `default:` clause), then propose an alternative fix which removes the `default:` clause and its code.

The first fix always retains the `default:` clause.

PiperOrigin-RevId: 713386272
@copybara-service copybara-service bot merged commit b12d133 into master Jan 8, 2025
@copybara-service copybara-service bot deleted the test_712971198 branch January 8, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant