Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unimplemented with todo #2594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randomPoison
Copy link
Collaborator

At some point we started using todo instead of unimplemented, but a couple places still use the old macro. May as well normalize on todo everywhere, since unimplemented is baaaaaaasically deprecated.

@fw-immunant
Copy link
Collaborator

It's fine to make things consistent everywhere, but since when is unimplemented! on the way out? I thought it was for functionality that isn't and shouldn't be implemented.

@randomPoison
Copy link
Collaborator Author

randomPoison commented Jan 30, 2025

Oh fair point, I didn't think about unimplemented meaning "deliberately unimplemented"

The difference between unimplemented! and todo! is that while todo! conveys an intent of implementing the functionality later and the message is “not yet implemented”, unimplemented! makes no such claims. Its message is “not implemented”.

So todo! still probably makes more sense for us to use in the exercise code, but unimplemented isn't deprecated in the way I thought.

@djmitche djmitche self-requested a review January 31, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants