Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ne_greenwald_fraction to PostProcessedOutputs #658

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

theo-brown
Copy link
Collaborator

@theo-brown theo-brown commented Jan 15, 2025

The Greenwald density fraction is generally useful. Having it in the simulation state is useful as I am interested in developing feedback controllers for density fuelling, with the Greenwald fraction as the target variable (eg #532).

@jcitrin
Copy link
Collaborator

jcitrin commented Jan 31, 2025

Thanks for this.

Can have a short discussion on appropriateness of line-averaged-density vs volume-averaged-density.

In the literature I think line-averaged-density is more often used. For a given machine it's easier to measure (no need for full geometry reconstruction) but at the same time the specific chord used is very machine specific.

Volume-averaged-density is less ambiguous.

However, if you are developing controllers for density feedback, then should think about what the appropriate synthetic diagnostic is. Is the fGW provided by the real diagnostic a line average with a specific chord, or volume averaged following geometry reconstruction? Likely the former, and then you'd probably want a more realistic synthetic diagnostic in TORAX with the actual chord, that would then necessitate more 2D geometry information propagated in TORAX etc etc.

For now happy to approve this volume averaged one, but wanted to raise the above points. Feel free to include some of these points in the docstring of the method if relevant. Am also wondering if the name should change to e.g. ne_volume_avg_fgw, or fgw_ne_volume_avg, or something like that, to accentuate the density used for the fraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants