Merge pull request #848 from hkad98/jkd/pdm-removal

chore: remove forgotten methods from PDM removal
gooddata · Oct 16, 2024 · 5b67382 · 5b67382
2 parents 1e7d953 + 2b0f633
commit 5b67382
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 137 deletions.
diff --git a/docs/content/en/latest/data/data-source/_index.md b/docs/content/en/latest/data/data-source/_index.md
@@ -16,7 +16,6 @@ See [Connect Data](https://www.gooddata.com/docs/cloud/connect-data/) to learn h
 * [get_data_source](./get_data_source/)
 * [delete_data_source](./delete_data_source/)
 * [list_data_sources](./list_data_sources/)
-* [list_data_source_tables](./list_data_source_tables/)
 * [patch_data_source_attributes](./patch_data_source_attributes/)
 
 ### Declarative Methods

diff --git a/docs/content/en/latest/data/data-source/list_data_source_tables.md b/docs/content/en/latest/data/data-source/list_data_source_tables.md
diff --git a/gooddata-sdk/gooddata_sdk/__init__.py b/gooddata-sdk/gooddata_sdk/__init__.py
@@ -25,7 +25,6 @@
     CatalogDeclarativeColumn,
     CatalogDeclarativeTable,
 )
-from gooddata_sdk.catalog.data_source.entity_model.content_objects.table import CatalogDataSourceTable
 from gooddata_sdk.catalog.data_source.entity_model.data_source import (
     CatalogDataSource,
     CatalogDataSourceBigQuery,

diff --git a/gooddata-sdk/gooddata_sdk/catalog/data_source/entity_model/content_objects/table.py b/gooddata-sdk/gooddata_sdk/catalog/data_source/entity_model/content_objects/table.py
diff --git a/gooddata-sdk/gooddata_sdk/catalog/data_source/service.py b/gooddata-sdk/gooddata_sdk/catalog/data_source/service.py
@@ -24,7 +24,6 @@
     CatalogDeclarativeTables,
     CatalogScanResultPdm,
 )
-from gooddata_sdk.catalog.data_source.entity_model.content_objects.table import CatalogDataSourceTable
 from gooddata_sdk.catalog.data_source.entity_model.data_source import CatalogDataSource
 from gooddata_sdk.catalog.entity import TokenCredentialsFromFile
 from gooddata_sdk.catalog.workspace.declarative_model.workspace.logical_model.ldm import CatalogDeclarativeModel
@@ -136,29 +135,10 @@ def list_data_sources(self) -> list[CatalogDataSource]:
         data_sources = load_all_entities_dict(get_data_sources)
         return [CatalogDataSource.from_api(ds) for ds in data_sources["data"]]
 
-    def list_data_source_tables(self, data_source_id: str) -> list[CatalogDataSourceTable]:
-        """Lists all the data source tables for a given data source.
-
-        Args:
-            data_source_id (str):
-                Data Source identification string. e.g. "demo"
-
-        Returns:
-            list[CatalogDataSourceTable]:
-                List of Data Source Table objects
-        """
-        get_data_source_tables = functools.partial(
-            self._entities_api.get_all_entities_data_source_tables,
-            data_source_id,
-            _check_return_type=False,
-        )
-        data_source_tables = load_all_entities_dict(get_data_source_tables, camel_case=False)
-        return [CatalogDataSourceTable.from_dict(dst, camel_case=False) for dst in data_source_tables["data"]]
-
     # Declarative methods are listed below
 
     def get_declarative_data_sources(self) -> CatalogDeclarativeDataSources:
-        """Retrieve all data sources, including their related physical data model.
+        """Retrieve all data sources.
 
         Args:
             None