Refactor Jolt-related project settings to only be read as-needed #101254
+138
−248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #101237, this refactors the
JoltProjectSettings
class to not just be a class of getters that themselves just callGLOBAL_GET
(which in some cases also get cached as astatic
variable) but instead a class of actual values.This is then coupled with
ProjectSettings::get_singleton()->connect("settings_changed", ...);
to read the settings again whenever they're changed, ensuring that we have up-to-date values without needing to callGLOBAL_GET
all the time.This might perhaps provide a tiny performance boost, but mostly just cleans things up a bit and lets us get rid of the caveat in the documentation about certain settings only being read once.
It should probably be noted that
bounce_velocity_threshold
can now technically be read from the physics thread (when usingphysics/3d/run_on_separate_thread
) while the main thread is writing to it, but given that it's afloat
I would assume that there are no concern about "torn reads" or anything like that, and having the most up-to-date value when reading it isn't really a concern in this case.