Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot XR update for Feb 2025 #1009

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Godot XR update for Feb 2025 #1009

merged 2 commits into from
Mar 6, 2025

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Feb 13, 2025 •
edited
Loading

Godot XR update for February 2025 by the XR team

Still needs a header image.

@Calinou Calinou added the topic:blog New blogposts and corrections label Feb 13, 2025
JohnVeness
JohnVeness reviewed Feb 13, 2025
View reviewed changes
collections/_article/godot-xr-update-feb-2025.md Outdated

As of version 1.0.0, the Godot Meta Toolkit supports v71 of the Platform SDK.

See [the "Getting started" guide in the documentation](https://godot-sdk-integrations.github.io/godot-meta-toolkit/manual/platform_sdk/getting_started.html) for more information!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [the "Getting started" guide in the documentation](https://godot-sdk-integrations.github.io/godot-meta-toolkit/manual/platform_sdk/getting_started.html) for more information!
See [the "Getting started" guide in the documentation](https://godot-sdk-integrations.github.io/godot-meta-toolkit/manual/platform_sdk/getting_started.html) for more information.

Sorry, I'm Mister Grumpy when I see too many exclamation marks!

@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from 3f98068 to 29644e9 Compare February 13, 2025 22:19
@BastiaanOlij
Copy link
Contributor Author

Fixed up most remarks, few I'd like the original authors to react on, @dsnopek @m4gr3d

@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from 29644e9 to 4e3658c Compare February 14, 2025 00:57
@BastiaanOlij BastiaanOlij changed the title New Godot XR update for Feb 2025 Godot XR update for Feb 2025 Feb 14, 2025
dsnopek
dsnopek reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great to me!

Here's the places to update the Meta Toolkit's version, and one additional note - but other than that, I think this is probably ready to go :-)

m4gr3d
m4gr3d approved these changes Feb 14, 2025
View reviewed changes
@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from 4e3658c to 94ede80 Compare February 17, 2025 01:40
@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from 94ede80 to db0b1ef Compare February 20, 2025 22:15
@BastiaanOlij
Copy link
Contributor Author

Updated, still needs a header image. If someone can poke around, I'll do a post on the XR discord and see if someone has something.

@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from db0b1ef to 49f18b4 Compare February 22, 2025 00:04
@BastiaanOlij BastiaanOlij marked this pull request as ready for review February 22, 2025 00:04
@BastiaanOlij
Copy link
Contributor Author

And we have a header image. This is ready for final review.

devloglogan
devloglogan reviewed Feb 26, 2025
View reviewed changes
Copy link

@devloglogan devloglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small nits. Now that the Meta Toolkit has a demo illustrating some uses of the Platform SDK, it might be worth a mention? It's linked at the bottom of the getting started doc (which we do link) so maybe not necessary.

@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch 3 times, most recently from f9bf303 to 6b30368 Compare February 28, 2025 07:46
@BastiaanOlij BastiaanOlij force-pushed the godot_xr_feb_2025_update branch from 6b30368 to 98c6d05 Compare February 28, 2025 07:48
@adamscott adamscott force-pushed the master branch 2 times, most recently from 25b0f65 to d7fb26a Compare February 28, 2025 14:20
@coppolaemilio coppolaemilio merged commit 3ec04f0 into godotengine:master Mar 6, 2025
1 check passed
@coppolaemilio
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@JohnVeness JohnVeness JohnVeness left review comments

@m4gr3d m4gr3d m4gr3d approved these changes

@devloglogan devloglogan devloglogan approved these changes

Assignees
No one assigned
Labels
topic:blog New blogposts and corrections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BastiaanOlij @coppolaemilio @dsnopek @m4gr3d @JohnVeness @devloglogan @Calinou