-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notes for Node exports #10396
base: master
Are you sure you want to change the base?
Notes for Node exports #10396
Conversation
Co-authored-by: Max Hilbrunner <[email protected]>
388cb60
to
d980d0d
Compare
Co-authored-by: Max Hilbrunner <[email protected]>
d980d0d
to
dcd5f30
Compare
Node exporting is only supported in Node-derived classes. When a Node is | ||
saved to a PackedScene, using ``Node`` or ``Array[Node]`` will store a | ||
reference to a Node in the scene, but using ``Array`` or ``Dictionary`` | ||
to store Nodes will cause a copy of each Node to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the latter is intentional behavior, it's more of an oversight. Although node export is implemented essentially as a hack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's how it works though and its something people can get tripped up on. Letting people know this is how it works is probably better than ignoring it, at least until the behaviour is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try not to document bugs or behavior that might change without clearly indicating this. Otherwise, users might rely on the behavior and use the documentation as an argument in discussions.
Added a note informing of behaviour of Node exports.