Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: break up blobindexer logic into smaller func and add unit tests #1327

Draft
wants to merge 25 commits into
base: staging
Choose a base branch
from
Draft

test: break up blobindexer logic into smaller func and add unit tests #1327

wants to merge 25 commits into from
+2,962 −330

Conversation

Monika-Bitfly
Copy link

@Monika-Bitfly Monika-Bitfly commented Feb 11, 2025 •
edited
Loading

  • Refactored blobindexer.go functions in the /blobindexer package by breaking them into smaller, more readable functions
  • Added S3Client and consapi Client mocks using mockery package
  • Added blobindexer_test.go unit tests
  • Fixed /consapi methods typo

@Monika-Bitfly
refactor: break down blobindexer.go index logic into smaller func for…
73d8df6 
… improved redability
@Monika-Bitfly
refactor: update BlobIndexerConfig
ca5f502
@Monika-Bitfly
refactor: update calculateMinBlobSlot & calculateStartSlot
46daca9
@Monika-Bitfly
test: add blobindexer tests
e77f61f
@Monika-Bitfly
refactor: update beacon header response type
a2d1f23
@Monika-Bitfly
test: update TestCalculateMinBlobSlot tests
4648634
@Monika-Bitfly
refactor: update estimated time to head calc
e39e2b5
@Monika-Bitfly
test: add blobindexer tests for calculateStartSlot, calculateEstimate…
4a229d2 
…dTimeToHeadDuration, calculateEstimatedTimeToHead, calculateBlobsPerSecond, calculateSlotsPerSecond & getLastIndexedFinalizedSlot func
@Monika-Bitfly
refactor: break down blobindexer.go indexBlobsAtSlot & indexBlobsInBa…
ed92d0e 
…tches logic for improved redability
@Monika-Bitfly
test: add blobindexer tests for validateSpec method
391c836
@Monika-Bitfly
refactor: update blob sidecards response type
a2ffca0
@Monika-Bitfly
fix: Proposal typo
0a675f9
@Monika-Bitfly
test: added ClientInt consapi mocks
c9e1250
@Monika-Bitfly
test: add blobindexer tests for fetchSpec, fetchBlockHeader & checkNo…
8e8db86 
…dePruning func
@Monika-Bitfly
fix: estimated time to head calculations
615e518
@Monika-Bitfly
test: add S3Client mocks
108d89e
@Monika-Bitfly
refactor: update BlobIndexerConfig S3 type
4dbcd94
@Monika-Bitfly
test: add blobindexer s3 tests
0a3e744
@Monika-Bitfly
test: add blobindexer TestPutBlob & TestPutIndexerStatus tests
7aa48af
@Monika-Bitfly
refactor: modularize Indexer struct into IndexerConfig and NodeConfig
448fc55
@Monika-Bitfly
test: add blobindexer TestNewBlobIndexer, TestIndexBlobsAtSlot, TestG…
af31e86 
…etIndexerStatus & TestProcessBlobs tests
@Monika-Bitfly
test: update TestPutIndexerStatus test
5fb67e2
@Monika-Bitfly
test: update timestamp in TestPutIndexerStatus test
2a7d6ce
@Monika-Bitfly
test: update TestPutIndexerStatus test
dccc32d
@Monika-Bitfly
refactor: rename s3.go to client.go
08db8f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Monika-Bitfly