BEDS 1140/vali group #1300
Open
BEDS 1140/vali group #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LuccaBitfly
commented
Jan 28, 2025
•
LuccaBitfly
commented
- if a validator was part of a dashboard and that dashboard had reached its limit, the validators group couldn't be changed when providing an index list
- fixed by this PR
LuccaBitfly
force-pushed
the
BEDS-1140/vali-group
branch
4 times, most recently
from
91feb1e to
418fa56
Compare
sasha-bitfly
requested changes
Jan 29, 2025
| @@ -241,10 +241,10 @@ func ConstantTimeDelay(start time.Time, intendedMinWait time.Duration) { | |||
| } | |||
| } | |||
|
|
|||
| func SliceToMap[T comparable](s []T) map[T]bool { | |||
| m := make(map[T]bool) | |||
| func SliceToMap[T comparable](s []T) map[T]struct{} { | |||
There was a problem hiding this comment.
@LuccaBitfly Please, write a unit test for this function
There was a problem hiding this comment.
@remoterami @LuccaBitfly
utils is the best file for us to start covering with the unit tests
especially I've seen places in a code where / 0 is possible
| @@ -827,6 +827,21 @@ func (d *DataAccessService) AddValidatorDashboardValidators(ctx context.Context, | |||
| return result, nil | |||
| } | |||
|
|
|||
| func (d *DataAccessService) GetValidatorDashboardValidatorsOfList(ctx context.Context, dashboardId t.VDBIdPrimary, validators []t.VDBValidator) ([]t.VDBValidator, error) { | |||
| var result []uint64 | |||
| q := `SELECT DISTINCT uvdv.validator_index | |||
There was a problem hiding this comment.
Should we wrap sql query in goqu?
|
Added minor comments, otherwise LGFM 👍 |
LuccaBitfly
force-pushed
the
BEDS-1140/vali-group
branch
4 times, most recently
from
6a80f3c to
685b2c9
Compare
- if a validator was part of a dashboard and that dashboard had reached its limit, the validators group couldn't be changed when providing an index list - fixed by this commit See: BEDS-1140
See: BEDS-1140
LuccaBitfly
force-pushed
the
BEDS-1140/vali-group
branch
from
685b2c9 to
72fa0d3
Compare
sasha-bitfly
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.