(BEDS-1173) using correct table for api keys #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| apiKey, err := utils.GenerateRandomAPIKey() | ||
| var userId uint64 | ||
| err := d.userWriter.GetContext(ctx, &userId, ` | ||
| INSERT INTO users (password, email, register_ts) |
There was a problem hiding this comment.
Does it make sense to wrap SQL query in goqu same as we did for test
There was a problem hiding this comment.
For simpler queries like this it's usually not required as it's not really worth it, with the additional error handling etc. readability isn't really increased. I'd consider it optional in such cases but if you insist, I can change it
There was a problem hiding this comment.
LGTM as soon as we added test
There was a problem hiding this comment.
I think the benefit of goqu is to validate the query before executing it. Wrapping or not is up to you.
sasha-bitfly
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.