-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: Update to Wizard and Styling Guide #12919
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12919 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 770 770
Lines 38945 38945
=======================================
Hits 36113 36113
Misses 2832 2832
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution! Unfortunately, some of the changes in this PR will have to be superseded by this PR due to the nature/quantity of the changes. #12716 and merging as-is would cause unnecessary merge conflicts.
Please do let me know when the duplicate part(s) are removed and i'd be happy to take a look at this
goauthentik#12716 Signed-off-by: NiceDevil <[email protected]>
Guess actual budget was the only one that was in the PR mentioned. So I took a look at the other changes on the PR you linked here. As I go over my old PRs files I found the setting:
Should this not be in all PRs that reference the Wizard to create the SP/App. And yes I know: Would be a story for an other day :) I guess the maingoal of all you nice guys here that are responsible for documentation want to change all guides to the Wizard at anytime. |
Actually, it's not just changing all to use the wizard, naming all throughout the docs also needs to get updated as the word "wizard" will no longer appear in the UI. As for the setting you found, I do believe the following sentence from the new template includes this: |
ok :) so this PR is there anything I should do right now? |
Used new knowledge on how to better contribute to update my "old" OAuth Docs.
Ty @dominic-r
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)