Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Update to Wizard and Styling Guide #12919

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nicedevil007
Copy link
Contributor

Used new knowledge on how to better contribute to update my "old" OAuth Docs.
Ty @dominic-r


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@nicedevil007 nicedevil007 requested a review from a team as a code owner February 2, 2025 09:22
Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 826716c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/679f9727f09d6600084bbace

Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 826716c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/679f9727d8cfff000903a8fd
😎 Deploy Preview https://deploy-preview-12919--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (7686d12) to head (826716c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12919   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         770      770           
  Lines       38945    38945           
=======================================
  Hits        36113    36113           
  Misses       2832     2832           
Flag Coverage Δ
e2e 48.54% <ø> (ø)
integration 24.59% <ø> (ø)
unit 90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution! Unfortunately, some of the changes in this PR will have to be superseded by this PR due to the nature/quantity of the changes. #12716 and merging as-is would cause unnecessary merge conflicts.

Please do let me know when the duplicate part(s) are removed and i'd be happy to take a look at this

@nicedevil007
Copy link
Contributor Author

nicedevil007 commented Feb 2, 2025

Guess actual budget was the only one that was in the PR mentioned. So I took a look at the other changes on the PR you linked here. As I go over my old PRs files I found the setting:

Select implicit or explicit authorization flow as desired.

Should this not be in all PRs that reference the Wizard to create the SP/App.

And yes I know: Would be a story for an other day :) I guess the maingoal of all you nice guys here that are responsible for documentation want to change all guides to the Wizard at anytime.

@dominic-r
Copy link
Contributor

Actually, it's not just changing all to use the wizard, naming all throughout the docs also needs to get updated as the word "wizard" will no longer appear in the UI. As for the setting you found, I do believe the following sentence from the new template includes this:
provide a name (or accept the auto-provided name), the authorization flow to use for this provider, and the following required configurations.

@nicedevil007
Copy link
Contributor Author

Actually, it's not just changing all to use the wizard, naming all throughout the docs also needs to get updated as the word "wizard" will no longer appear in the UI. As for the setting you found, I do believe the following sentence from the new template includes this: provide a name (or accept the auto-provided name), the authorization flow to use for this provider, and the following required configurations.

ok :) so this PR is there anything I should do right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants