-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: Beszel #12905
base: main
Are you sure you want to change the base?
website/integrations: Beszel #12905
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Used these commands after fresh git pull: make lint-fix && npx prettier --write ./website/integrations/services/beszel/index.mdx && make website Signed-off-by: NiceDevil <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12905 +/- ##
==========================================
- Coverage 92.75% 92.66% -0.09%
==========================================
Files 769 770 +1
Lines 38929 38945 +16
==========================================
- Hits 36109 36090 -19
- Misses 2820 2855 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This service utilizes Pocketbase as its backend. I believe it would be more beneficial to focus this PR on configuring authentik alongside Pocketbase, as it would support more use cases.
It would be more of a general purpose guide, then you could make a different page for Beszel, reference this guide, and add some service specific configuration. That's if you're up to it. Otherwise, I can review the PR as-is. Whatever works best for you. LMK what you prefer or if you have any questions/ideas. Just thinking long-term ATM |
I agree with you but I don't know how I can do that without the real tests beeing done. As you might know, I'm not that devguy that deploy own applications and use backends like pocketbase on developing ;) |
If that's what you prefer, sure. Tho, the UI the user is visiting ( |
ok, so I can do another PR for pocketbase, you take a look at it, if this is not going the right direction we stay to you "only" Beszel docs ok? |
I'll review the PR as-is for the moment. Thanks for yet another contribution to authentik. It is greatly appreciated. |
If that works best for you |
I can do it in parallel so maybe you will tell me "Nice...what are you trying to tell us with this guide..." and then this one is already close to be "merged" maybe :) |
Yea, that's perfect |
I ask here, because no new PR right now => do you have any information about the automatic/manual usercreation with pocketbase? Is this a feature Beszel added to it or is it always the same for this backend? |
ok so I assume I can remove the part with the user creation from the guide at all, because we are using the docs in default state to get authentik up and running and not with user choosen details on each application ;) |
so... I guess I'm done with the code for PocketBase... do you have an example for an already existing integration that relies on any other service that I can use as a template for Beszel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicedevil007, Thanks for yet another conribution to authentik! Real quick, could you also apply the same suggestions from the Pocketbase PR? I'll review the remaining changes once that's done.
As @4d62 suggestet, here is the much simpler version as it uses 1:1 settings from PocketBase
Details
Found a new tool that I tested and is able to use authentik for awesome login ;) Here is my guide.
For reference if you want to correct my english or just don't know what I wanted to describe without screenshots.
Here is the "default guide" found on the beszel homepage without the parts for authentik.
https://beszel.dev/guide/oauth
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)