-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: dynamically render index.mdx page for integrations #12897
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12897 +/- ##
=======================================
Coverage 92.72% 92.73%
=======================================
Files 770 770
Lines 38945 38945
=======================================
+ Hits 36113 36115 +2
+ Misses 2832 2830 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea for this (I think I experimented with something similar some time ago), especially with #12893 moving the support badge to the frontmatter making the first line in the card be an excerpt of the service.
One thing we should do in the future is add icons to these integrations, however we'd a) need to backport that for all existing services and b) figure out a better place to store them (I'm not a fan of putting them in this repo too)
LGTM from me, cc @tanberry for adding some copy on top of the integrations page and @kensternberg-authentik / @GirlBossRush for reviewing the react components
What?
This PR updates the default welcome page for integrations (at http://localhost:3000/integrations/) to be dynamically generated based on the existing integrations and sorted by category header. An updated version of #11341, but integrations are no longer sorted alphabetically, as it looked out of place to me.
Might be redundant to sort them twice by category? Once in the sidebar and once in the main page itself. I have a local copy of this component for when integrations are sorted alphabetically instead if that's what preferred by y'all.
Whatever option is chosen, I find it adds a nice touch and looks nicer than a few pixelated images. Mabye the menu on the left could be hidden on this page?
Do note I've rarely used React or frontend technology, this may be far from optimal. Created this PR for fun/necessity
How?
Testing:
make website-install
,make website-build
, andmake website-watch
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)