Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enterprise/stages/source: fix Source stage not executing authentication/enrollment flow #12875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 29, 2025

Details

closes #12872


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner January 29, 2025 16:50
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 832cafe
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/679a5d0e6f66cf0008fefc20

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 832cafe
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/679a5d0e0f240d00086924a3

@BeryJu BeryJu force-pushed the enterprise/stages/source/fix-authn-enroll-flow-not-running branch from c4bd8c2 to 832cafe Compare January 29, 2025 16:53
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (e41d86b) to head (832cafe).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/sources/flow_manager.py 21.05% 15 Missing ⚠️
authentik/enterprise/stages/source/stage.py 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12875      +/-   ##
==========================================
- Coverage   92.75%   92.73%   -0.02%     
==========================================
  Files         769      769              
  Lines       38929    38940      +11     
==========================================
+ Hits        36108    36112       +4     
- Misses       2821     2828       +7     
Flag Coverage Δ
e2e 48.56% <28.12%> (-0.01%) ⬇️
integration 24.60% <25.00%> (-0.01%) ⬇️
unit 90.38% <31.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-832cafee4336ae10e81cb218e3a8d6f1c0c6185e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-832cafee4336ae10e81cb218e3a8d6f1c0c6185e

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source stage does not execute source's enrollment/authentication flow
1 participant