Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle/migrate: don't migrate tenants if not enabled #12850

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rissson
Copy link
Member

@rissson rissson commented Jan 27, 2025

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Jan 27, 2025
@rissson rissson requested a review from a team as a code owner January 27, 2025 16:18
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c67681c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6797b1f245331a00084637d1

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit c67681c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6797b1f23900640008448a69

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (5109af0) to head (c67681c).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12850      +/-   ##
==========================================
- Coverage   92.75%   92.69%   -0.06%     
==========================================
  Files         769      769              
  Lines       38926    38926              
==========================================
- Hits        36106    36084      -22     
- Misses       2820     2842      +22     
Flag Coverage Δ
e2e 48.48% <ø> (-0.09%) ⬇️
integration 24.60% <ø> (ø)
unit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this doesn't break anything if the migration has already ran in the past

@rissson
Copy link
Member Author

rissson commented Jan 27, 2025

It doesn't. However, if tenants get re-enabled, they'll have to catch up

@rissson
Copy link
Member Author

rissson commented Jan 27, 2025

This might? cause issues if we were to squash migrations

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c67681c5d3f1b80eb2abe3da1dd2897f826805d5
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c67681c5d3f1b80eb2abe3da1dd2897f826805d5

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit 92d6d74 into main Jan 29, 2025
76 checks passed
@rissson rissson deleted the lifecycle-dont-migrate-tenants-if-not-enabled branch January 29, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants