-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations-all: add default values change warning #12777
website/integrations-all: add default values change warning #12777
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12777 +/- ##
==========================================
- Coverage 92.75% 92.69% -0.06%
==========================================
Files 769 769
Lines 38929 38929
==========================================
- Hits 36108 36085 -23
- Misses 2821 2844 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
sigh |
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: 4d62 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great note to add to all 100+ Integration guides, thanks @4d62 .
Signed-off-by: 4d62 <[email protected]>
Signed-off-by: 4d62 <[email protected]>
Signed-off-by: 4d62 <[email protected]>
sdko/integrations-all/values-changed-warning
From meeting: https://www.notion.so/authentiksecurity/Check-ins-17caee05b24e80a0aec6c7d508406435?pvs=4#1e85c3daa1e94d939f70acc5745a6c3f
What?
This PR adds a message under the preparation section of every integration guide mentioning that only values that have been changed from their defaults are mentioned in the guide + that configuration errors might lead to access errors
How?
Ran the following script from the root of the authentik repository:
There are a few scenarios where this didn't work:
If that was the case, the block was inserted manually. (Worked for almost all pages 75-80%)
What else?
Note update
The note's first sentence was updated. As a result, I ran the following command from the root of the authentik repository to find and replace:
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)