Reverted fix for go-swagger throws error on Windows if application path contains parentheses or blanks #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredbi
force-pushed
the
fix/146-path-with-parenthesis
branch
from
c9e8a04 to
8f9f2ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 63.41% 63.52% +0.10%
==========================================
Files 30 30
Lines 3075 3076 +1
==========================================
+ Hits 1950 1954 +4
+ Misses 951 949 -2
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
fix/146-path-with-parenthesis
branch
from
d32a15a to
a0e9715
Compare
fredbi
changed the title
fredbi
changed the title
fredbi
force-pushed
the
fix/146-path-with-parenthesis
branch
from
a0e9715 to
2bacc4b
Compare
fredbi
changed the title
A more thorough investigation on loading specs from a generated server from paths containing special characters (such as blank spaces, parenthesis) did not conclude that it was necessary to alter how cache entries are matched. Indeed, this change deeply altered how keys in the cache are managed and was therefore at best, a risky bet. * reverted commit e8e27ff * added check to ensure that the root pseudo-document is preloaded in cache under all conditions * added more unit tests to check the behavior of the normalizers against escaped characters * closes go-openapi#145 Signed-off-by: Frederic BIDON <[email protected]>
fredbi
force-pushed
the
fix/146-path-with-parenthesis
branch
from
2bacc4b to
e89509c
Compare
casualjim
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.