Allow to set kernel on machine level #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will allow us to set custom kernel and initrd on machine level like this |
obbardc
reviewed
Oct 30, 2022
avoidik
force-pushed
the
feature/allow-to-override-kernel
branch
from
5da1ebf to
1151914
Compare
avoidik
changed the title
obbardc
requested changes
Jul 17, 2023
| @@ -49,37 +49,37 @@ func warnLocalhost(variable string, value string) { | |||
| Consider using an address that is valid on your network.` | |||
|
|
|||
| if strings.Contains(value, "localhost") || | |||
| strings.Contains(value, "127.0.0.1") || | |||
| strings.Contains(value, "::1") { | |||
| strings.Contains(value, "127.0.0.1") || | |||
There was a problem hiding this comment.
spurious go format changes shouldnt be included in this commit
| CPUs int `short:"c" long:"cpus" description:"Number of CPUs to use for build VM (default: 2)"` | ||
| Memory string `short:"m" long:"memory" description:"Amount of memory for build VM (default: 2048MB)"` | ||
| ShowBoot bool `long:"show-boot" description:"Show boot/console messages from the fake machine"` | ||
| KernelPath string `short:"k" long:"kernel" description:"kernel to use"` |
There was a problem hiding this comment.
I think we should make this option a little more dynamic, something like:
--fakemachine-backend-option kernel-path:kernel.img
if err = m.SetBackendOption("key", "value"); err != nil {
// show error to user
}
|
closing in favour of go-debos/fakemachine#192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on go-debos/fakemachine#119