Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing volk_16_byteswap_u_orc to puppet #719

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

argilo
Copy link
Member

@argilo argilo commented Dec 9, 2023

volk_16u_byteswap_u_orc is not tested or profiled, because it does not have a wrapper in volk_16u_byteswappuppet_16u. Here I've added the missing wrapper.

The volk_16u_byteswap_u_orc protokernel seems to work fine, and has perforance comparable to the others:

$ apps/volk_profile -n -R byteswappuppet_16u
Warning: this IS a dry-run. Config will not be written!
RUN_VOLK_TESTS: volk_16u_byteswappuppet_16u(131071,1987)
generic completed in 54.6349 ms
u_sse2 completed in 41.4502 ms
a_sse2 completed in 40.915 ms
u_avx2 completed in 28.288 ms
a_avx2 completed in 28.9922 ms
u_orc completed in 32.8863 ms
Best aligned arch: u_avx2
Best unaligned arch: u_avx2

@argilo argilo added the bug label Dec 9, 2023
Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdemel jdemel merged commit dde2d5a into gnuradio:main Dec 10, 2023
32 checks passed
@argilo argilo deleted the byteswap-16u-orc branch January 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants