Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reth to 2933ec7 #51

Merged
merged 8 commits into from
Feb 18, 2025
Merged

Bump reth to 2933ec7 #51

merged 8 commits into from
Feb 18, 2025

Conversation

debjit-bw
Copy link
Member

@debjit-bw debjit-bw commented Feb 11, 2025

Upgraded the upstream reth version from 4eb65250a7430bf8699e1128f472b9cf842a54ae to 2933ec72987df396d1d3411323dc2260b522aab2.

This was necessary because in 4eb652, reth used the chainspec-specified blob params in some places, while the default mainnet params in others. This upgrade makes it consistent.

The updates are 1:1 with reth except:

  • Refactoring payload_builder to extract the payload-specific logic to its own file. This is consistent with what reth does for ethereum (payload vs payload builder in node. This logic was already present in payload_builder here, but with the recent change in trait bounds, it needed to be separated to different files.
  • GnosisEvmConfig::new parses the eip1559collector from the chain_spec instead of taking it as an input param
  • In CI, cache@v2 was changed to cache@v3 because CI test runs were failing due to v2 being deprecated.

All other changes reflect upstream changes.

@debjit-bw debjit-bw requested a review from dapplion February 11, 2025 18:01
@debjit-bw debjit-bw marked this pull request as ready for review February 11, 2025 21:56
@debjit-bw debjit-bw requested a review from dapplion February 12, 2025 12:04
Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dapplion dapplion changed the title Upgrade feb 10 Bump reth to 2933ec7 Feb 18, 2025
@debjit-bw debjit-bw merged commit 78f69aa into master Feb 18, 2025
7 checks passed
@debjit-bw debjit-bw deleted the upgrade-feb-10 branch February 18, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants