Merge pull request #69 from gladly-team/spicer/remove-Sovrn

Removed Sovrn as an ad partner
gladly-team · Dec 16, 2023 · 3324385 · 3324385
2 parents f73f1f1 + f086820
commit 3324385
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 74 deletions.
diff --git a/README.md b/README.md
@@ -90,7 +90,6 @@ Here's what to check for each partner, assuming the iframed page is `https://exa
 | OpenX  | `https://tabforacause-d.openx.net/w/1.0/arj`  | Query param `ju` is `https://example.com/newtab/` |
 | Pulsepoint  | `https://bid.contextweb.com/header/ortb`  | Payload `site.page` and `site.ref` are both `https://example.com/newtab/`  |
 | Sonobi  | `apex.go.sonobi.com/trinity.json`  | Query param `ref` is `https://example.com/newtab/` |
-| Sovrn  | `https://ap.lijit.com/rtb/bid`  | Payload `site.domain` is `example.com` and `site.page` is `https://example.com/newtab/`  |
 | Unruly  | `https://targeting.unrulymedia.com/unruly_prebid`  | Payload `refererInfo.referer` is `https://example.com/newtab/`  |
 
 **GDPR and CCPA:** We should manually ensure that data privacy preferences are passed to ad partners. We use [`tab-cmp`](https://github.com/gladly-team/tab-cmp) as our consent management platform. See `tab-cmp`'s "Ad Partners" sections of its [test checklist](https://github.com/gladly-team/tab-cmp#test-checklist) for what to verify in ad partner requests.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tab-ads",
-  "version": "1.1.23",
+  "version": "1.1.24",
   "description": "An NPM package to manage ads logic for Tab for a Cause",
   "main": "build/index.js",
   "repository": "[email protected]:gladly-team/tab-ads.git",

diff --git a/src/providers/prebid/__tests__/prebidBidder.test.js b/src/providers/prebid/__tests__/prebidBidder.test.js
@@ -199,7 +199,6 @@ describe('prebidBidder: fetchBids', () => {
       'pulsepoint',
       'rubicon',
       'sonobi',
-      'sovrn',
       'triplelift',
       'unruly',
     ])
@@ -213,7 +212,6 @@ describe('prebidBidder: fetchBids', () => {
       'pulsepoint',
       'rubicon',
       'sonobi',
-      'sovrn',
       'triplelift',
       'unruly',
     ])
@@ -227,7 +225,6 @@ describe('prebidBidder: fetchBids', () => {
       'pulsepoint',
       'rubicon',
       'sonobi',
-      'sovrn',
       'triplelift',
       'unruly',
     ])

diff --git a/src/providers/prebid/built/pb.js b/src/providers/prebid/built/pb.js
diff --git a/src/providers/prebid/modules.json b/src/providers/prebid/modules.json
@@ -8,7 +8,6 @@
   "unrulyBidAdapter",
   "pulsepointBidAdapter",
   "sonobiBidAdapter",
-  "sovrnBidAdapter",
   "tripleliftBidAdapter",
   "ixBidAdapter",
   "kueezRtbBidAdapter",

diff --git a/src/providers/prebid/prebidBidder.js b/src/providers/prebid/prebidBidder.js
@@ -63,12 +63,6 @@ const getPrebidAdUnit = (tabAdUnit, config) => {
               ct: '460981',
             },
           },
-          {
-            bidder: 'sovrn',
-            params: {
-              tagid: '438918',
-            },
-          },
           {
             bidder: 'openx',
             params: {
@@ -179,12 +173,6 @@ const getPrebidAdUnit = (tabAdUnit, config) => {
               ct: '460982',
             },
           },
-          {
-            bidder: 'sovrn',
-            params: {
-              tagid: '438916',
-            },
-          },
           {
             bidder: 'openx',
             params: {
@@ -287,12 +275,6 @@ const getPrebidAdUnit = (tabAdUnit, config) => {
               ct: '665497',
             },
           },
-          {
-            bidder: 'sovrn',
-            params: {
-              tagid: '589343',
-            },
-          },
           {
             bidder: 'openx',
             params: {

diff --git a/src/utils/test-fixtures.js b/src/utils/test-fixtures.js
@@ -159,13 +159,6 @@ export const storeA = {
             advertiserName: 'openx',
             adSize: '728x90',
           },
-          {
-            adId: 'div-gpt-ad-1464385677836-0',
-            revenue: 0.00004000000000000001,
-            encodedRevenue: null,
-            advertiserName: 'sovrn',
-            adSize: '728x90',
-          },
         ],
         'div-gpt-ad-1464385742501-0': [
           {
@@ -234,46 +227,6 @@ export const storeA = {
               },
               status: 'targetingSet',
             },
-            {
-              bidderCode: 'sovrn',
-              width: 728,
-              height: 90,
-              statusMessage: 'Bid available',
-              adId: '355b96e0098c9f4',
-              requestId: '691d5c2dd12933',
-              mediaType: 'banner',
-              source: 'client',
-              ad: '<div>some ad </div>',
-              cpm: 0.04000000000000001,
-              creativeId: '2162612',
-              pubapiId: '117392992498624437',
-              currency: 'USD',
-              netRevenue: true,
-              ttl: 60,
-              originalCpm: 0.05,
-              originalCurrency: 'USD',
-              auctionId: 'c33e9ff3-c2d4-48a2-8b33-553235d27028',
-              responseTimestamp: 1582766489938,
-              requestTimestamp: 1582766489660,
-              bidder: 'sovrn',
-              adUnitCode: 'div-gpt-ad-1464385677836-0',
-              timeToRespond: 278,
-              pbLg: '0.00',
-              pbMg: '0.00',
-              pbHg: '0.04',
-              pbAg: '0.00',
-              pbDg: '0.04',
-              pbCg: '',
-              size: '728x90',
-              adserverTargeting: {
-                hb_bidder: 'sovrn',
-                hb_adid: '355b96e0098c9f4',
-                hb_pb: '0.00',
-                hb_size: '728x90',
-                hb_source: 'client',
-                hb_format: 'banner',
-              },
-            },
           ],
         },
         'div-gpt-ad-1464385742501-0': {