Deduplicate stacks #223

hendrikvanantwerpen · 2023-03-15T18:27:21Z

Implements an interning Arena that is used for deduplicating symbol and scope stacks.

github-actions · 2023-03-15T18:40:21Z

Performance Summary

Comparing base 4840877 with head bd83ec0 on microsoft/[email protected]. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.643^                     ##                                                 
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #     ::                                 :         
     |                    :#     :                                  :     :@  
     |                    :#     :            :                     :     :@  
     |                    :#     :            :                    ::   :::@  
     |      @@  @@      @@:#     :            :                    ::   :::@  
     |      @   @       @ :#   :::        :   :                   :::   :::@  
     |      @  :@   :  :@ :#   : :     @:::  ::       :           ::: :::::@  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   192.5

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.835^                                                               ##       
     |                                                               #        
     |                                                               #        
     |                                                               #        
     |                                                               #        
     |                                                             ::#        
     |                  @::     @@                                 : #     @  
     |         @@       @:      @                                  : #     @  
     |         @        @:      @                                 :: #     @  
     |         @        @:     :@            :                    :: #   ::@  
     |         @   :  ::@:     :@            :                    :: #  :: @  
     |        :@   :  : @:   :::@     @@::   :       ::         :::: # ::: @  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   242.3

github-actions · 2023-03-17T15:05:47Z

Performance Summary

Comparing base 4840877 with head 5afabb3 on microsoft/[email protected]. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.643^                     ##                                                 
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #     ::                                 :         
     |                    :#     :                                  :     :@  
     |                    :#     :            :                     :     :@  
     |                    :#     :            :                    ::   :::@  
     |      @@  @@      @@:#     :            :                    ::   :::@  
     |      @   @       @ :#   :::        :   :                   :::   :::@  
     |      @  :@   :  :@ :#   : :     @:::  ::       :           ::: :::::@  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   192.5

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
5.064^                                ##                                      
     |                               :#                            :::    ::  
     |                        :      :#                            :::    ::  
     |                        :      :#                            :::    ::  
     |                        :      :#                            :::    ::  
     |              @@        :      :#                            :::    ::  
     |         @@:::@         :    :::#                            :::    @:  
     |         @ :::@        @:    :::#      ::                    :::   :@:  
     |        @@ :::@ @      @:    :::#      :                     :::   :@:  
     |        @@ :::@ @      @:   @:::#      :                   :::::  ::@:  
     |       :@@ :::@ @     :@:   @:::#      :                   : :::  ::@:  
     |    :  :@@ :::@ @     :@:   @:::#   :  :  :: :      :      : :::::::@:  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   245.6

github-actions · 2023-03-17T15:35:08Z

Performance Summary

Comparing base 4840877 with head 0a3fd73 on microsoft/[email protected]. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.643^                     ##                                                 
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #     ::                                 :         
     |                    :#     :                                  :     :@  
     |                    :#     :            :                     :     :@  
     |                    :#     :            :                    ::   :::@  
     |      @@  @@      @@:#     :            :                    ::   :::@  
     |      @   @       @ :#   :::        :   :                   :::   :::@  
     |      @  :@   :  :@ :#   : :     @:::  ::       :           ::: :::::@  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   192.5

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
9.065^                                  #                                     
     |                                  #                                     
     |                                  #                                     
     |                                  #                                     
     |                                  #                                     
     |                                  #                                     
     |                         :      ::#                           ::     :  
     |                         :      ::#                           ::     :  
     |              @          :      ::#                           ::     :  
     |         @::::@ :       ::   ::@::#      :                  @:::   :@:  
     |        @@::: @::       ::  :: @::#      :                  @:::  ::@:  
     |       :@@::: @:::     :::  :: @::#     ::  :        :     :@:::  ::@:  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   254.9

github-actions · 2023-03-20T11:13:10Z

Performance Summary

Comparing base 4840877 with head 1caa5ee on microsoft/[email protected]. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.643^                     ##                                                 
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #                                                  
     |                     #     ::                                 :         
     |                    :#     :                                  :     :@  
     |                    :#     :            :                     :     :@  
     |                    :#     :            :                    ::   :::@  
     |      @@  @@      @@:#     :            :                    ::   :::@  
     |      @   @       @ :#   :::        :   :                   :::   :::@  
     |      @  :@   :  :@ :#   : :     @:::  ::       :           ::: :::::@  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   192.5

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript analyze --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
4.773^                                                              #         
     |                    @                                         #     ::  
     |                    @                                         #     ::  
     |                    @                                         #     ::  
     |                    @                                         #     ::  
     |                    @                                         #     ::  
     |                  ::@    ::        :                        ::#    :@:  
     |         @        ::@    ::        :                        ::#    :@:  
     |         @        ::@    ::        :                       :::#    :@:  
     |     :   @      ::::@    ::        :   :                   :::#  :::@:  
     |     : ::@      ::::@  ::::       ::   :       :  :      @::::#  :::@:  
     |     : : @  :  :::::@  : ::     ::::  ::      ::  :      @::::#:::::@:  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   257.7

hendrikvanantwerpen self-assigned this Mar 15, 2023

hendrikvanantwerpen added 12 commits March 20, 2023 11:40

Add interning arena

5861201

Introduce arena trait

2acf777

Support any Arena for ReversibleList

9f67447

Support any Arena for Deque

cb6f651

Support any Arena for List

b778098

Bring back nice arena types

0a00cc9

Add traits to various arena types

d7e108e

Replace derived Niche implementation with explicit trait-friendly ones

296a72f

Run arena tests against both implementations

1f2cb0a

Switch to HashArena for PartialPaths

b4b84ea

Use HashArena for symbol stack keys

5f9f4ae

Use handle equality

1caa5ee

hendrikvanantwerpen force-pushed the stack-dedup branch from 0a3fd73 to 1caa5ee Compare March 20, 2023 11:02

hendrikvanantwerpen changed the base branch from main to stack-orientation March 20, 2023 11:03

hendrikvanantwerpen changed the title ~~Deduplicate stacks~~ [Performance Experiment] Deduplicate stacks Mar 30, 2023

hendrikvanantwerpen added the performance label Mar 30, 2023

hendrikvanantwerpen changed the title ~~[Performance Experiment] Deduplicate stacks~~ Deduplicate stacks Mar 30, 2023

hendrikvanantwerpen removed their assignment Jul 3, 2023

hendrikvanantwerpen mentioned this pull request Jul 17, 2023

Add clone instances for arenas #292

Closed

hendrikvanantwerpen self-assigned this Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deduplicate stacks #223

Deduplicate stacks #223

hendrikvanantwerpen commented Mar 15, 2023

github-actions bot commented Mar 15, 2023

github-actions bot commented Mar 17, 2023

github-actions bot commented Mar 17, 2023

github-actions bot commented Mar 20, 2023

Deduplicate stacks #223

Are you sure you want to change the base?

Deduplicate stacks #223

Conversation

hendrikvanantwerpen commented Mar 15, 2023

github-actions bot commented Mar 15, 2023

Performance Summary

github-actions bot commented Mar 17, 2023

Performance Summary

github-actions bot commented Mar 17, 2023

Performance Summary

github-actions bot commented Mar 20, 2023

Performance Summary