Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to include pull requests targeting the release branch #160

Closed
wants to merge 6 commits into from

Conversation

malancas
Copy link
Contributor

No description provided.

Copy link
Collaborator

@codysoyland codysoyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One request though: could you re-do it without all the whitespace changes? (i.e. stage specific lines instead of the entire files?) Otherwise, we will end up doing more work resolving merge conflicts, for example I have an open PR upstream that changes a lot of matrix values which would conflict with a lot of this.

Signed-off-by: Meredith Lancaster <[email protected]>
@malancas
Copy link
Contributor Author

Thanks for doing this! One request though: could you re-do it without all the whitespace changes? (i.e. stage specific lines instead of the entire files?) Otherwise, we will end up doing more work resolving merge conflicts, for example I have an open PR upstream that changes a lot of matrix values which would conflict with a lot of this.

Removed all the auto-formatting, the only change now is to target the "release" branch.

malancas and others added 3 commits May 22, 2024 15:38
* update release workflow

Signed-off-by: Meredith Lancaster <[email protected]>

* Grab image digest for attestation step

Signed-off-by: Meredith Lancaster <[email protected]>

* comment

Signed-off-by: Meredith Lancaster <[email protected]>

* update workflow name

Signed-off-by: Meredith Lancaster <[email protected]>

* add release directions

Signed-off-by: Meredith Lancaster <[email protected]>

* undo ko config changes

Signed-off-by: Meredith Lancaster <[email protected]>

* add fork specific options to ko build call

Signed-off-by: Meredith Lancaster <[email protected]>

* Change version format

---------

Signed-off-by: Meredith Lancaster <[email protected]>
Co-authored-by: Cody Soyland <[email protected]>
@malancas malancas closed this May 28, 2024
@malancas malancas deleted the update-e2e-test-branch-targets branch June 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants