Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-generic-link-text rule #10

Merged
merged 17 commits into from
Dec 21, 2022
+203 −38
Merged

Add no-generic-link-text rule #10

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b64b572
Move to helper
khiga8 Aug 26, 2022
7f778c1
Add test file
khiga8 Aug 26, 2022
def43d6
Add no-generic-link-text rule
khiga8 Aug 26, 2022
24071c4
Add tests with punctuation
khiga8 Aug 29, 2022
b908be6
Update tests and account for blank link
khiga8 Aug 29, 2022
550896e
Ensure rule is configured
khiga8 Dec 20, 2022
aa094d7
Add rule to accessibility
khiga8 Dec 20, 2022
0f42a59
Fix tests and run linter
khiga8 Dec 20, 2022
85b876e
More updates
khiga8 Dec 20, 2022
b63e5e2
Make tests more robust
khiga8 Dec 20, 2022
4ce66a8
Allow additional words to be configured
khiga8 Dec 21, 2022
cce4a05
Run lint
khiga8 Dec 21, 2022
f5b1e48
Allow rule params to be configured
khiga8 Dec 21, 2022
7ebcdee
Add test
khiga8 Dec 21, 2022
91d4422
Rebase conflicts
khiga8 Dec 21, 2022
1bf18ae
Clean up code
khiga8 Dec 21, 2022
4269133
Move helper out and add tests
khiga8 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run lint
@khiga8
khiga8 committed Dec 21, 2022
commit cce4a057282b85d4c75f95d5900ac43f7d46707c
4 changes: 3 additions & 1 deletion no-generic-link-text.js
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,9 @@ module.exports = {
tags: ["accessibility", "links"],
function: function GH002(params, onError) {
// markdown syntax
const allBannedLinkTexts = bannedLinkText.concat(params.config.banned_link_texts || [])
const allBannedLinkTexts = bannedLinkText.concat(
params.config.banned_link_texts || []
);
const inlineTokens = params.tokens.filter((t) => t.type === "inline");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found markdown-it demo and using the debug functionality helpful for understanding how markdown is parsed.

Additionally, I referenced: md042.

for (const token of inlineTokens) {
const { children } = token;