Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linked issue be assigned to the PR #36014

Closed
wants to merge 3 commits into from

Conversation

Michael21107
Copy link
Contributor

Why:

Closes #35979
and fixes a minor grammar error.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • .github/PULL_REQUEST_TEMPLATE.md

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 21, 2025
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • .github/PULL_REQUEST_TEMPLATE.md

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@nguyenalex836
Copy link
Contributor

@Michael21107 Apologies, it looks like PULL_REQUEST_TEMPLATE.md is a file we are unable to accept contributions to. I'll create an internal PR to have the template updated - thank you again for raising the flag on this, and for the time you took to raise this PR 💛

@Michael21107
Copy link
Contributor Author

Michael21107 commented Jan 22, 2025

@nguyenalex836 No problem, thank you Alex for your work on this. ❤️
May I ask where is the complete list of files that can't be accepted for PRs?

@Michael21107 Michael21107 deleted the patch-1 branch January 22, 2025 13:20
@nguyenalex836
Copy link
Contributor

@Michael21107 It's my pleasure! 🙇 I believe this message captures all of the files that we can't accept contributions for!

@Michael21107
Copy link
Contributor Author

I understand. But isn't the list in some stand-alone docs, so people can see without having to ''be sent'' that message due to them opening a ''faulty'' PR?

@nguyenalex836
Copy link
Contributor

@Michael21107 That's a great point - let me discuss making that restricted list more visible with the team, and see what options we could consider 💛 thank you for advocating for that!

@Michael21107
Copy link
Contributor Author

@nguyenalex836 Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better auto-closing issues in PR template
2 participants