Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct spelling of 'noFineGrainedAccess' #35998

Closed
wants to merge 2 commits into from

Conversation

fyvri
Copy link

@fyvri fyvri commented Jan 20, 2025

Why:

This PR fixes a minor typo in the variable name noFineGrainedAcccess by removing the extra "c". Ensuring correct variable names improves code readability and consistency.

What's being changed (if available, include any code snippets, screenshots, or gifs):

The variable name noFineGrainedAcccess has been corrected to noFineGrainedAccess by removing the extra "c".

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

Copy link

welcome bot commented Jan 20, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/rest/components/RestAuth.tsx

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 20, 2025
@Tadmanakub

This comment was marked as spam.

@Tadmanakub

This comment was marked as spam.

Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/rest/components/RestAuth.tsx

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@nguyenalex836
Copy link
Contributor

@fyvri Thank you for raising this PR! ✨ It looks like as our bot noted, we are unfortunately unable to accept contributions to the file you are attempting to modify.

We'll open an issue internally to have this reviewed to have this typo reviewed 💛 Thank you for your willingness to contribute to our docs!

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team rest Content related to rest - overview. and removed triage Do not begin working on this issue until triaged by the team labels Jan 20, 2025
@fyvri
Copy link
Author

fyvri commented Jan 20, 2025

Thank you for reviewing my PR and for your kind response! 😊 I completely understand that contributions to this file are restricted, and I appreciate you opening an internal issue to address the typo. I’m glad I could help in some small way, and I look forward to contributing to other parts of the docs in the future! 🤍

@nguyenalex836
Copy link
Contributor

It's my pleasure, @fyvri! Thank you so much for your enthusiasm in elevating our docs to new heights! 🚀

If you're looking for other issues to pick up, take a look at our help wanted section to find open issues you can work on! ✨

@fyvri
Copy link
Author

fyvri commented Jan 20, 2025

Thank you so much for your encouragement! 🚀 I really appreciate the opportunity to contribute, and I’ll definitely check out the help wanted section to find other issues I can work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team rest Content related to rest - overview.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants