Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme #35821 #35851

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

thedarkking01
Copy link
Contributor

@thedarkking01 thedarkking01 commented Jan 7, 2025

Why:

According to the style guide, you should use backticks to format references to file names and directory names in a monospaced font.

Closes: #35821

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@thedarkking01 thedarkking01 changed the title Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme #35821 Fix: Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme #35821 Jan 7, 2025
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review labels Jan 7, 2025
@nguyenalex836
Copy link
Contributor

@thedarkking01 Thanks so much for opening a PR with these fixes! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into github:main with commit 6014cb8 Jan 7, 2025
70 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Mehdisirjani3510
Copy link

Mehdisirjani3510 commented Jan 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use backticks to format file name in adding-a-theme-to-your-github-pages-site-using-jekyll#adding-a-theme
3 participants