Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Support arguments and instantiations of template template parameters #18360

Merged
merged 5 commits into from
Jan 6, 2025
Merged

C++: Support arguments and instantiations of template template parameters #18360

merged 5 commits into from
Jan 6, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 22, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Dec 22, 2024
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 22, 2024
@jketema jketema force-pushed the jketema/template-parameters-3 branch from 102cc38 to d02a4ec Compare December 23, 2024 20:06
@jketema jketema force-pushed the jketema/template-parameters-3 branch 4 times, most recently from 96bc406 to 94909ce Compare December 25, 2024 10:03
@jketema jketema force-pushed the jketema/template-parameters-3 branch from 94909ce to 9f8a8c6 Compare January 2, 2025 17:02
@jketema jketema force-pushed the jketema/template-parameters-3 branch from 9f8a8c6 to 8e66019 Compare January 2, 2025 20:32
@jketema jketema marked this pull request as ready for review January 2, 2025 21:10
@jketema jketema requested a review from a team as a code owner January 2, 2025 21:10
@jketema jketema mentioned this pull request Jan 2, 2025
Merged
7 tasks
calumgrant
calumgrant previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Fix the typo now or later.

cpp/ql/lib/semmlecode.cpp.dbscheme Show resolved Hide resolved
cpp/ql/lib/semmle/code/cpp/TemplateParameter.qll Outdated Show resolved Hide resolved
@jketema jketema merged commit 01a7a53 into main Jan 6, 2025
12 of 16 checks passed
@jketema jketema deleted the jketema/template-parameters-3 branch January 6, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calumgrant calumgrant calumgrant approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @calumgrant