Merge branch 'main' into redsun82/swift-ios

github · Jan 17, 2025 · 2961749 · 2961749
2 parents 8c54f51 + d8ec6dd
commit 2961749
Show file tree

Hide file tree

Showing 85 changed files with 3,206 additions and 1,785 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -125,6 +125,7 @@ use_repo(
     "vendor__serde_with-3.12.0",
     "vendor__stderrlog-0.6.0",
     "vendor__syn-2.0.96",
+    "vendor__toml-0.8.19",
     "vendor__tracing-0.1.41",
     "vendor__tracing-subscriber-0.3.19",
     "vendor__tree-sitter-0.24.6",

diff --git a/cpp/ql/lib/DefaultOptions.qll b/cpp/ql/lib/DefaultOptions.qll
@@ -54,11 +54,11 @@ class Options extends string {
    *
    * By default, this holds for `exit`, `_exit`, `_Exit`, `abort`,
    * `__assert_fail`, `longjmp`, `__builtin_unreachable` and any
-   * function with a `noreturn` or `__noreturn__` attribute or
-   * `noreturn` specifier.
+   * function with a `noreturn`, `__noreturn__`, or `_Noreturn`
+   * attribute or `noreturn` specifier.
    */
   predicate exits(Function f) {
-    f.getAnAttribute().hasName(["noreturn", "__noreturn__"])
+    f.getAnAttribute().hasName(["noreturn", "__noreturn__", "_Noreturn"])
     or
     f.getASpecifier().hasName("noreturn")
     or

diff --git a/cpp/ql/lib/change-notes/2025-01-16-noreturn.md b/cpp/ql/lib/change-notes/2025-01-16-noreturn.md
@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* `DefaultOptions::exits` now holds for C23 functions with the `_Noreturn` or `___Noreturn__` attribute.