Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Implements Carbon namespacing #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alindeman
Copy link
Contributor

statsd supports namespacing. For instance with a global namespace of stats and a counter namespace of counters, all counters would be namespaced as stats.counters.foo.

This PR implements statsd's namespacing logic (except for legacy namespacing, which I don't think we should be encouraging) in brubeck. Namespacing is not enabled by default, but can be configured in config.json.

Feedback welcomed 💚

@alindeman alindeman force-pushed the namespacing branch 2 times, most recently from 1f55e9c to 922b484 Compare March 18, 2016 15:14
@alindeman alindeman force-pushed the namespacing branch 2 times, most recently from 1bb8460 to 8812227 Compare June 16, 2016 18:06
@blak3r2
Copy link

blak3r2 commented Oct 29, 2016

For what it's worth, I have tested this pull request and it worked for me.

If you want to use carbon-namespacing then add the following options to your backend type carbon:

      "global_prefix" : "stats",
      "prefix_counter" : "counters",
      "prefix_timer" : "timers",
      "prefix_histo" : "histos",
      "prefix_gauge" : "gauges"

@eugenepaniot
Copy link

+1

@StevenACoffman
Copy link

@vmg @carlosmn this works for us as well. Merge?

@ghost
Copy link

ghost commented Aug 30, 2017

Is this dead? :)

@vmg
Copy link
Contributor

vmg commented Aug 30, 2017

Generally speaking, we don't merge any features which we don't actively use in GitHub because we're afraid of unexpected side effects. This PR looks correct, however. If you really need this feature I'd advise you to carry this patch on a fork of brubeck.

@haggy
Copy link

haggy commented Aug 26, 2019

we don't merge any features which we don't actively use in GitHub because we're afraid of unexpected side effects

@vmg Why even bother open sourcing this then?

everpcpc added a commit to douban/brubeck that referenced this pull request Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants