Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobster language support #7204

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

inferrna
Copy link

Description

@inferrna inferrna requested a review from a team as a code owner January 18, 2025 18:37
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't need that many samples. 2-3 of the most representative of common usage is enough.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cached copy of the grammars licence should have been created when you ran the script/add-grammar command. This file needs to be included in this PR.

@inferrna
Copy link
Author

I added a license file. Also I did re-upload https://github.com/inferrna/lobster_ling repo. Originally it was a fork of https://github.com/aardappel/lobster which seemed a little too much.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert your last two changes. Submodule names are based on the upstream repo name. Your upstream repo is still lobster_ling so the submodule name should remain lobster_ling too. If you want to rename the submodule, rename your repo and re-add the grammar.

@lildude lildude dismissed their stale review January 21, 2025 10:17

Comments all addressed

@lildude lildude requested a review from a team January 21, 2025 10:17
@lildude
Copy link
Member

lildude commented Jan 21, 2025

PR looks good now. The language isn't popular enough for inclusion yet so I'll leave this pending popularity and review. Popularity is re-assessed each time a new release is made (~ every 3-4 months). This issue will not be updated with each check and there's no need to keep merging master in but please keep an eye on the PR and address any conflicts if they crop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants