-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated contributing.md #210
Conversation
@khareyash05 Please refer to commit message formats in the contributing guideline |
@khareyash05 Do not use too many |
Removed Fixes and Added Chore |
Sure! I will look into that |
@khareyash05 Please update the commit message to |
Used HTML tag to align image instead of |
Thank you @khareyash05 for all the changes. There is something called |
@gauravdas014 I am sorry I dont know about it. Could you pls guide me through it |
Definitely. |
@gauravdas014 will this work ? |
Yes. The 2 means Head will point to the second last commit. Then you will get the option to delete or edit commits. Delete the wrongly formatted commit message and then you need to force push to your repo. |
@khareyash05 Please give your PR to the dev branch. |
@gauravdas014 Have a look Am I done with all the changes you wanted |
It still showing 2 commits. As it is your first contribution, I can squash from my side also. Would you want me to do that? |
@gauravdas014 I would be highly grateful if you could do the same Thank you very much |
I am actually a bit confused in this ...I will learn this and will squash on my own from the next PR |
No problem. Just make sure you learn squashing, it will be useful in the future too. I know I have asked you to make too many changes in your very first pr, but that's how we learn. Open source is all about contributing, learning new things and also following the standards which the repo is maintaining. Good work @khareyash05 |
Definitely, no issue at all. Whenever you need any help feel free to ask. The open-source community is generous enough. |
Thank You @gauravdas014 . Do I have to make any more changes to the same? |
No. All changes have been made. Thank you and Good luck with your open source journey. |
@gauravdas014 May I know this issue is under which label in GSSOC'21 |
Level1 |
Could you please add a GSSOC label to the issue? |
@khareyash05 The issue that corresponds to this PR i.e. #209 already had a gssoc21 label to it. 👍 |
@gauravdas014 @pkspyder007 Could you pls add a level label and a GSSOC label to the PR as well because adding a level label to the PR is only being counted |
With reference to issue #209
docs: update contributing guide