add tests for the chart #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumEnigmaa
force-pushed
the
add-tests
branch
2 times, most recently
from
4375d80 to
7a4ec91
Compare
QuantumEnigmaa
force-pushed
the
add-tests
branch
from
7a4ec91 to
6c7eb45
Compare
|
Tests are failing in a strange way 🤔 |
hervenicol
reviewed
Aug 2, 2024
Co-authored-by: Hervé Nicol <[email protected]>
| @pytest.mark.flaky(reruns=5, reruns_delay=10) | ||
| def test_pods_available(ic_deployment: List[pykube.Deployment]): | ||
| for s in ic_deployment: | ||
| assert int(s.obj["status"]["readyReplicas"]) == int( |
There was a problem hiding this comment.
Line break feels weird at the end but sure
There was a problem hiding this comment.
Python weirdiness I guess 🤷
QuentinBisson
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3615
Checklist