Skip to content

Commit

Permalink
add server-tokens: "false" to IC config (#402)
Browse files Browse the repository at this point in the history
* add server-tokens: "false" to IC config

When you hit a non-existing endpoint on CP, the default backend is adding their server token in the headers and on the default HTML.
This is recognized as a security issue.

Adding server-tokens: "false" will remove it. IT's already in place in TC

* add changelog

Signed-off-by: Julien Garcia Gonzalez <[email protected]>
  • Loading branch information
Julien Garcia Gonzalez authored Oct 29, 2020
1 parent d77cca3 commit 3235dcb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `server-tokens: "false"` to Nginx Ingress Controller to remove the server tokens from the default backend response body and answer.

### Deleted

- Delete Kubernetes API readonly role/binding.
Expand Down
3 changes: 2 additions & 1 deletion templates/files/k8s-resource/ingress-controller-cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ data:
variables-hash-bucket-size: "128"
server-name-hash-bucket-size: "1024"
server-name-hash-max-size: "1024"
worker-processes: "4"
server-tokens: "false"
worker-processes: "4"

0 comments on commit 3235dcb

Please sign in to comment.