Skip to content

Commit

Permalink
add repo to image registry patch
Browse files Browse the repository at this point in the history
Signed-off-by: Puja Abbassi <[email protected]>
  • Loading branch information
puja108 committed Dec 18, 2024
1 parent 5b80367 commit cc458bb
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 8 deletions.
4 changes: 2 additions & 2 deletions diffs/helm__envoy-gateway__templates___helpers.tpl.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/vendor/gateway-helm/templates/_helpers.tpl b/helm/envoy-gateway/templates/_helpers.tpl
index d9aefc2..d3bb56d 100644
index d9aefc2..2645585 100644
--- a/vendor/gateway-helm/templates/_helpers.tpl
+++ b/helm/envoy-gateway/templates/_helpers.tpl
@@ -40,6 +40,7 @@ helm.sh/chart: {{ include "eg.chart" . }}
Expand All @@ -17,7 +17,7 @@ index d9aefc2..d3bb56d 100644
-{{- if .Values.deployment.envoyGateway.image.repository }}
-{{- .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Values.global.images.envoyGateway.tag | default .Chart.AppVersion }}
+{{- if .Values.image.registry }}
+{{- .Values.image.registry }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
+{{- .Values.image.registry }}/{{- .Values.image.repository }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
{{- else if .Values.global.images.envoyGateway.image }}
{{- .Values.global.images.envoyGateway.image }}
{{- else }}
9 changes: 5 additions & 4 deletions diffs/helm__envoy-gateway__values.yaml.patch
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
diff --git a/vendor/gateway-helm/values.yaml b/helm/envoy-gateway/values.yaml
index 56cf308..810dabd 100644
index 56cf308..7979274 100644
--- a/vendor/gateway-helm/values.yaml
+++ b/helm/envoy-gateway/values.yaml
@@ -22,11 +22,14 @@ podDisruptionBudget:
@@ -22,11 +22,15 @@ podDisruptionBudget:
minAvailable: 0
# maxUnavailable: 1

+image:
+ registry: gsoci.azurecr.io
+ repository: giantswarm
+
deployment:
envoyGateway:
Expand All @@ -19,15 +20,15 @@ index 56cf308..810dabd 100644
imagePullPolicy: ""
imagePullSecrets: []
resources:
@@ -44,6 +47,7 @@ deployment:
@@ -44,6 +48,7 @@ deployment:
runAsNonRoot: true
runAsGroup: 65532
runAsUser: 65532
+ readOnlyRootFilesystem: true
seccompProfile:
type: RuntimeDefault
ports:
@@ -88,11 +92,15 @@ createNamespace: false
@@ -88,11 +93,15 @@ createNamespace: false

kubernetesClusterDomain: cluster.local

Expand Down
1 change: 1 addition & 0 deletions helm/envoy-gateway/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ To uninstall the chart:
| global.images.ratelimit.pullPolicy | string | `"IfNotPresent"` | |
| global.images.ratelimit.pullSecrets | list | `[]` | |
| image.registry | string | `"gsoci.azurecr.io"` | |
| image.repository | string | `"giantswarm"` | |
| kubernetesClusterDomain | string | `"cluster.local"` | |
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |
Expand Down
2 changes: 1 addition & 1 deletion helm/envoy-gateway/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The name of the Envoy Gateway image.
*/}}
{{- define "eg.image" -}}
{{- if .Values.image.registry }}
{{- .Values.image.registry }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
{{- .Values.image.registry }}/{{- .Values.image.repository }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
{{- else if .Values.global.images.envoyGateway.image }}
{{- .Values.global.images.envoyGateway.image }}
{{- else }}
Expand Down
1 change: 1 addition & 0 deletions helm/envoy-gateway/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ podDisruptionBudget:

image:
registry: gsoci.azurecr.io
repository: giantswarm

deployment:
envoyGateway:
Expand Down
2 changes: 1 addition & 1 deletion sync/patches/image-registry/000-image-registry.patch
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ index d9aefc2..cdadc41 100644
-{{- if .Values.deployment.envoyGateway.image.repository }}
-{{- .Values.deployment.envoyGateway.image.repository }}:{{ .Values.deployment.envoyGateway.image.tag | default .Values.global.images.envoyGateway.tag | default .Chart.AppVersion }}
+{{- if .Values.image.registry }}
+{{- .Values.image.registry }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
+{{- .Values.image.registry }}/{{- .Values.image.repository }}/{{- .Values.deployment.envoyGateway.image.name }}:{{ .Values.deployment.envoyGateway.image.tag | default .Chart.AppVersion }}
{{- else if .Values.global.images.envoyGateway.image }}
{{- .Values.global.images.envoyGateway.image }}
{{- else }}
1 change: 1 addition & 0 deletions sync/patches/values/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ podDisruptionBudget:

image:
registry: gsoci.azurecr.io
repository: giantswarm

deployment:
envoyGateway:
Expand Down

0 comments on commit cc458bb

Please sign in to comment.