Fix text selection when dragging window with hidden titlebar #5286
+26
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
macos-titlebar-style i
s set tohidden
, dragging the window near thetitlebar area would inadvertently trigger text selection. This was caused
by the
mouseDown
event being passed to the surface even when in thetitlebar region.
The fix improves the logic in
mouseDown
handler to properly handle windowdragging without triggering text selection when clicking in the titlebar
area. This provides a smoother window dragging experience while preserving
expected text selection behavior in the terminal area.
demo.mov
Fixes #5259