Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gtk/toggle_fullscreen): header bar visibility #5050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pseudocc
Copy link

While unfullscreen the window, header.setVisible(true) will be called. For .gtk it's okay, because it will follows the window-decoration, while .adw doesn't.

After #4850, the header is always created and added to the window, so setting visibility to the correct value is vital for .adw.

Fixes: #4850

While unfullscreen the window, header.setVisible(true) will be called.
For .gtk it's okay, because it will follows the window-decoration, while
.adw doesn't.

After ghostty-org#4850, the header is always created and added to the window, so
setting visibility to the correct value is vital for .adw.

Fixes: ghostty-org#4850
@jcollie
Copy link
Collaborator

jcollie commented Jan 14, 2025

Unfortunately, the interaction between window-decoration, gtk-titlebar and the various options for toggling window state are poorly specified. Because my reading of the documentation comments is different, and it could be seen as a bug that the titlebar doesn't reappear after toggling fullscreen. We need to have a larger discussion on these options and come up with ways that users can clearly express their intentions for window decoration and titlebars. Until that happens, any PRs that change the behavior are just going to cause additional churn when people with differing interpretations report bugs or submit PRs.

@pseudocc
Copy link
Author

pseudocc commented Jan 14, 2025

Unfortunately, the interaction between window-decoration, gtk-titlebar and the various options for toggling window state are poorly specified.

  • True.

@jcollie But I am not proposing a behavior change, I am trying to keep it as it was (before the previous PR), the previous PR makes gtk and adw behave differently.

Expected and actual

window-decoration=false, gtk-adwaita=true

steps has titlebar
1. launch ghostty (non-fullscreened) no
2. fullscreen no
3. unfullscreen yes(before the previos PR, no)

window-decoration=false, gtk-adwaita=false

steps has titlebar
1. launch ghostty (non-fullscreened) no
2. fullscreen no
3. unfullscreen no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants