Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add save instruction to +list-themes #4902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Aaron-212
Copy link

Close #4731

image

@mitchellh mitchellh enabled auto-merge January 12, 2025 15:22
auto-merge was automatically disabled January 14, 2025 03:15

Head branch was pushed to by a user without write access

@Aaron-212 Aaron-212 force-pushed the list-theme-save branch 2 times, most recently from 1d5633a to 6455b28 Compare January 14, 2025 03:23
@jainhitesh9998
Copy link

@Aaron-212 @mitchellh.

ghostty doesnt create a config file by default right?
I'm using it in mac and had to create it manually at either XDG or ~/.config/ghostty/config.

if this specific reference can be added in the +list-themes functionality or a default empty config is created during installation, it'll make things more accessible to a lot of people.

themes is probably only customization most do.

i have had a few of my friends try ghostty.
the terminal enthusiasts customized it to their liking really fast. the occasional users took some time going through the docs or needed help.

@pluiedev
Copy link
Contributor

ghostty doesnt create a config file by default right? I'm using it in mac and had to create it manually at either XDG or ~/.config/ghostty/config.

It does. #3460

@mitchellh
Copy link
Contributor

Note @pluiedev there's some bugs in 1.0.1 where if the dir doesn't exist we don't create the file. I think these were resolved on tip though.

src/cli/list_themes.zig Show resolved Hide resolved
src/cli/list_themes.zig Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing <enter> in +list-themes should explain how to save theme
5 participants